Add support for non-GET requests #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Rack documentation, those headers are not supported through the HTTP_ variables: https://www.rubydoc.info/github/rack/rack/file/SPEC#The_Environment
|
Hi guys! Any progress on this one? Can be useful for applications that doesn't have GET routes at all |
|
Bump |
mateusg
changed the title
|
Instead of extending running of curl, will it be better to allow to provide a path to some script that will be triggered, and encapsulate there all those curl or non curl commands? |
|
+1 |
julohaq22
approved these changes
Jun 8, 2022
|
+1 |
|
merged in as #234, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for #121. I needed this myself while running some perf tests this week, so I took the opportunity to patch the gem, clean up and add tests.
I also had to find a way to set the
Content-Typeheader, because the request I was testing was a JSON request and the gem did not support setting that header throughHTTP_variables (looks like it's a restriction from Rack, actually).Another thing I had to do was disable the CSRF protection before initializing the app. I did that because non-GET requests require an authenticity token and I couldn't find a way to generate a valid one from the
Rails.applicationcontext. I'm open to suggestions.I really appreciate the work you've done with this gem @schneems (and everyone else who has contributed), it has helped me so much to investigate and find the memory leaks. It felt like I had everything I needed in a single tool. 🙂👏